Re: [PATCH 5/9] nvme: move the fast path nvme error and disposition helpers
From: Jens Axboe <axboe@kernel.dk>
Date: 2021-10-13 14:41:34
Also in:
linux-nvme
From: Jens Axboe <axboe@kernel.dk>
Date: 2021-10-13 14:41:34
Also in:
linux-nvme
On 10/13/21 12:57 AM, Christoph Hellwig wrote:
Please Cc the nvme list for nvme changes.quoted
-static inline enum nvme_disposition nvme_decide_disposition(struct request *req) -{ - if (likely(nvme_req(req)->status == 0)) - return COMPLETE;I think the only part here that needs to be inline is this check. The rest is all slow path error handling.
I think I'll just kill this patch and check nvme_req(req)->status in the caller. If it's non-zero, just do the normal completion path and skip the batch list. -- Jens Axboe