Thread (33 messages) 33 messages, 4 authors, 2021-10-13

Re: [PATCH 1/9] block: add a struct io_batch argument to fops->iopoll()

From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-10-12 18:25:10

On 10/12/21 11:17 AM, Jens Axboe wrote:
-int bio_poll(struct bio *bio, unsigned int flags)
+int bio_poll(struct bio *bio, struct io_batch *ib, unsigned int flags)
  {
How about using the name 'iob' instead of 'ib' for the io_batch 
argument? When I saw the 'ib' argument name that name made me wonder for 
a second whether it is perhaps related to InfiniBand.
+struct io_batch {
+	struct request *req_list;
+	void (*complete)(struct io_batch *);
+};
Function pointers are not ideal in high-performance code. Is there 
another solution than introducing a new function pointer?

Thanks,

Bart.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help