Thread (37 messages) 37 messages, 5 authors, 2019-01-10

Re: [PATCH 11/16] io_uring: batch io_kiocb allocation

flat view

From: Jens Axboe <axboe@kernel.dk>
Date: 2019-01-09 16:58:02
Also in: linux-arch, linux-fsdevel

On 1/9/19 5:13 AM, Christoph Hellwig wrote:
quoted
+	if (!state)
+		req = kmem_cache_alloc(kiocb_cachep, GFP_KERNEL);
Just return an error here if kmem_cache_alloc fails.
quoted
+	if (req)
+		io_req_init(ctx, req);
Because all the other ones can't reached this with a NULL req.
This is different in the current tree, since I properly fixed the
ctx ref issue.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help