Re: [PATCH 11/16] io_uring: batch io_kiocb allocation

On 1/9/19 5:13 AM, Christoph Hellwig wrote:

quoted

+	if (!state)
+		req = kmem_cache_alloc(kiocb_cachep, GFP_KERNEL);

Just return an error here if kmem_cache_alloc fails.

quoted

+	if (req)
+		io_req_init(ctx, req);

Because all the other ones can't reached this with a NULL req.

This is different in the current tree, since I properly fixed the
ctx ref issue.

-- 
Jens Axboe

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>