Re: [PATCH 06/16] io_uring: support for IO polling

On 1/9/19 5:11 AM, Christoph Hellwig wrote:

On Tue, Jan 08, 2019 at 09:56:35AM -0700, Jens Axboe wrote:

quoted

Add polled variants of the read and write commands. These act like their
non-polled counterparts, except we expect to poll for completion of
them.

These aren't really need command variants, but a different type of context.

That is phrased poorly, I'll fix that.

quoted

 	case IORING_OP_FSYNC:
+		if (ctx->flags & IORING_SETUP_IOPOLL)
+			break;
 		ret = io_fsync(&req->fsync, iocb, false);
 		break;
 	case IORING_OP_FDSYNC:
+		if (ctx->flags & IORING_SETUP_IOPOLL)
+			break;
 		ret = io_fsync(&req->fsync, iocb, true);

I'd move this check into io_fsync to avoid a little duplication.

Done

-- 
Jens Axboe