Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI
From: Kees Cook <hidden>
Date: 2018-05-22 23:32:04
Also in:
linux-ide, linux-scsi, lkml
Subsystem:
block layer, the rest · Maintainers:
Jens Axboe, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2018-05-24 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Christoph Hellwig <hch@infradead.org>
- 2018-05-23 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Kees Cook <hidden>
- 2018-05-23 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · "Martin K. Petersen" <martin.petersen@oracle.com>
- 2018-05-22 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Christoph Hellwig <hch@infradead.org>
- 2018-05-22 · [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Kees Cook <hidden>
On Tue, May 22, 2018 at 12:16 PM, Jens Axboe [off-list ref] wrote:
On 5/22/18 1:13 PM, Christoph Hellwig wrote:quoted
On Tue, May 22, 2018 at 01:09:41PM -0600, Jens Axboe wrote:quoted
I think Martin and Christoph are objecting to moving the code to block/scsi_ioctl.h. I don't care too much about where the code is, but think it would be nice to have the definitions in a separate header. But if they prefer just pulling in all of SCSI for it, well then I guess it's pointless to move the header bits. Seems very heavy handed to me, though.It might be heavy handed for the 3 remaining users of drivers/ide,Brutal :-)
Heh. I noticed a similar sense buffer use in drivers/cdrom/cdrom.c too. Is this okay under the same considerations?
diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index ad9b687a236a..220ff321c102 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig@@ -79,7 +79,7 @@ config GDROM tristate "SEGA Dreamcast GD-ROM drive" depends on SH_DREAMCAST select CDROM - select BLK_SCSI_REQUEST # only for the generic cdrom code + select SCSI help A standard SEGA Dreamcast comes with a modified CD ROM drive called a "GD-ROM" by SEGA to signify it is capable of reading special disks
@@ -345,7 +345,7 @@ config CDROM_PKTCDVD tristate "Packet writing on CD/DVD media (DEPRECATED)" depends on !UML select CDROM - select BLK_SCSI_REQUEST + select SCSI help Note: This driver is deprecated and will be removed from the kernel in the near future!
diff --git a/drivers/block/paride/Kconfig b/drivers/block/paride/Kconfig
index f8bd6ef3605a..7fdfcc5eaca5 100644
--- a/drivers/block/paride/Kconfig
+++ b/drivers/block/paride/Kconfig@@ -27,7 +27,7 @@ config PARIDE_PCD tristate "Parallel port ATAPI CD-ROMs" depends on PARIDE select CDROM - select BLK_SCSI_REQUEST # only for the generic cdrom code + select SCSI ---help--- This option enables the high-level driver for ATAPI CD-ROM devices connected through a parallel port. If you chose to build PARIDE
quoted
but as long as that stuff just keeps working I'd rather worry about everyone else, and keep the scsi code where it belongs.Fine with me then, hopefully we can some day kill it off.
I'll send a v2. I found a few other things to fix up (including the cdrom.c one). Thanks! -Kees -- Kees Cook Pixel Security