Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI
From: Christoph Hellwig <hch@infradead.org>
Date: 2018-05-22 19:13:20
Also in:
linux-ide, linux-scsi, lkml
Possibly related (same subject, not in this thread)
- 2018-05-24 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Christoph Hellwig <hch@infradead.org>
- 2018-05-23 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Kees Cook <hidden>
- 2018-05-23 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · "Martin K. Petersen" <martin.petersen@oracle.com>
- 2018-05-22 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Christoph Hellwig <hch@infradead.org>
- 2018-05-22 · [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Kees Cook <hidden>
On Tue, May 22, 2018 at 01:09:41PM -0600, Jens Axboe wrote:
I think Martin and Christoph are objecting to moving the code to block/scsi_ioctl.h. I don't care too much about where the code is, but think it would be nice to have the definitions in a separate header. But if they prefer just pulling in all of SCSI for it, well then I guess it's pointless to move the header bits. Seems very heavy handed to me, though.
It might be heavy handed for the 3 remaining users of drivers/ide, but as long as that stuff just keeps working I'd rather worry about everyone else, and keep the scsi code where it belongs.