Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI
From: Kees Cook <hidden>
Date: 2018-05-22 18:59:13
Also in:
linux-ide, linux-scsi, lkml
Possibly related (same subject, not in this thread)
- 2018-05-24 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Christoph Hellwig <hch@infradead.org>
- 2018-05-23 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Kees Cook <hidden>
- 2018-05-23 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · "Martin K. Petersen" <martin.petersen@oracle.com>
- 2018-05-22 · Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Christoph Hellwig <hch@infradead.org>
- 2018-05-22 · [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI · Kees Cook <hidden>
On Tue, May 22, 2018 at 11:50 AM, Martin K. Petersen [off-list ref] wrote:
Christoph,quoted
On Tue, May 22, 2018 at 11:15:09AM -0700, Kees Cook wrote:quoted
Both SCSI and ATAPI share the sense header. In preparation for using the struct scsi_sense_hdr more widely, move this into a separate header and move the helper function to scsi_ioctl.c which is linked with CONFIG_IDE by way of CONFIG_BLK_SCSI_REQUEST.Please keep the code where it is and just depend on SCSI on the legacy ide driver. No need to do gymnastics just for a legacy case.Yup, I agree.
Oh, er, this was mainly done at Jens's request. Jens, can you advise? -Kees -- Kees Cook Pixel Security