Re: [PATCH 31/31] xen/scsifront: Remove code that zeroes driver-private command data
From: Hannes Reinecke <hare@suse.de>
Date: 2017-05-24 06:15:01
Also in:
linux-scsi
On 05/24/2017 02:34 AM, Bart Van Assche wrote:
quoted hunk ↗ jump to hunk
Since the SCSI core zeroes driver-private command data, remove that code from the xen-scsifront driver. Signed-off-by: Bart Van Assche <redacted> Cc: Juergen Gross <jgross@suse.com> Cc: xen-devel@lists.xenproject.org --- drivers/scsi/xen-scsifront.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index a6a8b60d4902..36f59a1be7e9 100644 --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c@@ -534,7 +534,6 @@ static int scsifront_queuecommand(struct Scsi_Host *shost, int err; sc->result = 0; - memset(shadow, 0, sizeof(*shadow)); shadow->sc = sc; shadow->act = VSCSIIF_ACT_SCSI_CDB;
Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)