Re: [PATCH 07/31] scsi: Use blk_mq_rq_to_pdu() to convert a request to a SCSI command pointer
From: Hannes Reinecke <hare@suse.de>
Date: 2017-05-24 05:54:09
Also in:
linux-scsi
From: Hannes Reinecke <hare@suse.de>
Date: 2017-05-24 05:54:09
Also in:
linux-scsi
On 05/24/2017 02:33 AM, Bart Van Assche wrote:
Since commit e9c787e65c0c ("scsi: allocate scsi_cmnd structures as
part of struct request") struct request and struct scsi_cmnd are
adjacent. This means that there is now an alternative to reading
req->special to convert a pointer to a prepared request into a
SCSI command pointer, namely by using blk_mq_rq_to_pdu(). Make
this change where appropriate. Although this patch does not
change any functionality, it slightly improves performance and
slightly improves readability.
Signed-off-by: Bart Van Assche <redacted>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Johannes Thumshirn <redacted>
---
drivers/scsi/scsi_error.c | 2 +-
drivers/scsi/scsi_lib.c | 18 +++++++++---------
include/scsi/scsi_tcq.h | 2 +-
3 files changed, 11 insertions(+), 11 deletions(-)Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)