Re: [PATCH 14/31] cdrom: Check private request size before attaching to a queue
From: Hannes Reinecke <hare@suse.de>
Date: 2017-05-24 06:02:32
Also in:
linux-scsi
On 05/24/2017 02:34 AM, Bart Van Assche wrote:
quoted hunk ↗ jump to hunk
Since the cdrom driver only supports request queues for which struct scsi_request is the first member of their private request data, refuse to register block layer queues for which this is not the case. References: commit 82ed4db499b8 ("block: split scsi_request out of struct request") Signed-off-by: Bart Van Assche <redacted> Cc: Jens Axboe <axboe@fb.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Omar Sandoval <redacted> Cc: Hannes Reinecke <hare@suse.com> Cc: linux-block@vger.kernel.org --- drivers/cdrom/cdrom.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index 76c952fd9ab9..070568d496dc 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c@@ -594,6 +594,10 @@ int register_cdrom(struct cdrom_device_info *cdi) if (cdo->open == NULL || cdo->release == NULL) return -EINVAL; + if (!blk_queue_scsi_sup(cdi->disk->queue)) { + WARN_ONCE(true, "Attempt to register a non-SCSI queue\n"); + return -EINVAL; + } if (!banner_printed) { pr_info("Uniform CD-ROM driver " REVISION "\n"); banner_printed = 1;
Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)