Thread (72 messages) 72 messages, 4 authors, 2017-02-16

Re: [PATCH 6/8] blk-mq-sched: add framework for MQ capable IO schedulers

From: Paolo Valente <hidden>
Date: 2016-12-22 15:20:12
Also in: lkml

Il giorno 21 dic 2016, alle ore 03:22, Jens Axboe [off-list ref] ha =
scritto:
=20
On Tue, Dec 20 2016, Paolo Valente wrote:
quoted
quoted
+	else
+		rq =3D __blk_mq_alloc_request(data, op);
+
+	if (rq) {
+		rq->elv.icq =3D NULL;
+		if (e && e->type->icq_cache)
+			blk_mq_sched_assign_ioc(q, rq, bio);
=20
bfq needs rq->elv.icq to be consistent in bfq_get_request, but the
needed initialization seems to occur only after mq.get_request is
invoked.
=20
Can you do it from get/put_rq_priv?
Definitely, I just overlooked them, sorry :(

Thanks,
Paolo
The icq is assigned there. If not,
we can redo this part, not a big deal.
=20
--=20
Jens Axboe
=20
--
To unsubscribe from this list: send the line "unsubscribe linux-block" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help