Thread (72 messages) 72 messages, 4 authors, 2017-02-16

Re: [PATCH 6/8] blk-mq-sched: add framework for MQ capable IO schedulers

From: Jens Axboe <axboe@fb.com>
Date: 2016-12-21 02:22:35
Also in: lkml

On Tue, Dec 20 2016, Paolo Valente wrote:
quoted
+	else
+		rq = __blk_mq_alloc_request(data, op);
+
+	if (rq) {
+		rq->elv.icq = NULL;
+		if (e && e->type->icq_cache)
+			blk_mq_sched_assign_ioc(q, rq, bio);
bfq needs rq->elv.icq to be consistent in bfq_get_request, but the
needed initialization seems to occur only after mq.get_request is
invoked.
Can you do it from get/put_rq_priv? The icq is assigned there. If not,
we can redo this part, not a big deal.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help