Thread (32 messages) 32 messages, 5 authors, 2016-10-12

Re: [PATCH v2 6/7] SRP transport: Port srp_wait_for_queuecommand() to scsi-mq

From: Bart Van Assche <hidden>
Date: 2016-10-05 21:52:05
Also in: linux-nvme, linux-rdma, linux-scsi

On 10/05/2016 10:38 AM, Sagi Grimberg wrote:
quoted
+static void srp_mq_wait_for_queuecommand(struct Scsi_Host *shost)
+{
+    struct scsi_device *sdev;
+    struct request_queue *q;
+
+    shost_for_each_device(sdev, shost) {
+        q = sdev->request_queue;
+
+        blk_mq_quiesce_queue(q);
+        blk_mq_resume_queue(q);
+    }
+}
+
This *should* live in scsi_lib.c. I suspect that
various drivers would really want this functionality.
Hello Sagi,

There are multiple direct blk_*() calls in other SCSI transport drivers. 
So my proposal is to wait with moving this code into scsi_lib.c until 
there is a second user of this code.

Bart.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help