Thread (32 messages) 32 messages, 5 authors, 2016-10-12

Re: [PATCH v2 6/7] SRP transport: Port srp_wait_for_queuecommand() to scsi-mq

From: Christoph Hellwig <hch@lst.de>
Date: 2016-10-11 16:44:17
Also in: linux-nvme, linux-rdma, linux-scsi

On Wed, Oct 05, 2016 at 02:51:50PM -0700, Bart Van Assche wrote:
There are multiple direct blk_*() calls in other SCSI transport drivers. So 
my proposal is to wait with moving this code into scsi_lib.c until there is 
a second user of this code.
I still don't think these low-level difference for blk-mq vs legacy
request belong into a scsi LLDD.  So I concur with Sagi that this
should go into the core SCSI code.

In fact I suspect we should just call it directly from
scsi_internal_device_block, and maybe even scsi_internal_device_unblock
for case of setting the device offline.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help