Thread (20 messages) flat view 20 messages, 2 authors, 4d ago

Re: [PATCH v9 3/9] thermal/drivers/exynos: Handle optional triminfo clock correctly

From: Anand Moon <hidden>
Date: 2026-09-15 04:45:30
Also in: linux-pm, linux-samsung-soc, lkml

Hi Krzysztof,

Thanks for your review comments.
On Mon, 14 Sept 2026 at 12:37, Krzysztof Kozlowski [off-list ref] wrote:
On 13/09/2026 16:58, Anand Moon wrote:
quoted
The triminfo clock is obtained using devm_clk_get_optional_prepared(),
No, it is not. It is devm_clk_get().
The data->clk_sec checks were changed to handle the NULL return
 from devm_clk_get_optional_prepared() its only used by Exynos5420.
Order your patches correctly or do not introduce bugs in patch #1 which
you then fixup in next patch.
I will reorder / fix the series so that the clock API conversion and
the error NULL
handling are introduced together.
Best regards,
Krzysztof
Thanks
-Anand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help