[PATCH v9 5/9] thermal/drivers/exynos: Remove redundant base_second register resource
From: Anand Moon <hidden>
Date: 2026-09-13 15:00:03
Also in:
linux-pm, linux-samsung-soc, lkml
Subsystem:
samsung thermal driver, the rest, thermal · Maintainers:
Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski, Linus Torvalds, Rafael J. Wysocki, Daniel Lezcano
The Exynos5420 TRIMINFO register can be accessed through the main TMU register space, so a separate register mapping is not required. Remove the base_second member and the corresponding second resource mapping from the driver. Access EXYNOS_TMU_REG_TRIMINFO through the main TMU base address for all supported SoCs. Also simplify the triminfo reload handling by directly using the appropriate reload register for Exynos3250, Exynos4412 and Exynos5250. Signed-off-by: Anand Moon <redacted> --- drivers/thermal/samsung/exynos_tmu.c | 39 +++++----------------------- 1 file changed, 6 insertions(+), 33 deletions(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index a38b48e2236a..82cb4140646a 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c@@ -139,12 +139,11 @@ enum soc_type { * struct exynos_tmu_data : A structure to hold the private data of the TMU * driver * @base: base address of the single instance of the TMU controller. - * @base_second: base address of the common registers of the TMU controller. * @irq: irq number of the TMU controller. * @soc: id of the SOC type. * @lock: lock to implement synchronization. * @clk: pointer to the clock structure. - * @clk_sec: pointer to the clock structure for accessing the base_second. + * @clk_sec: pointer to the clock structure for accessing triminfo registers. * @sclk: pointer to the clock structure for accessing the tmu special clk. * @cal_type: calibration type for temperature * @efuse_value: SoC defined fuse value
@@ -172,7 +171,6 @@ enum soc_type { */ struct exynos_tmu_data { void __iomem *base; - void __iomem *base_second; int irq; enum soc_type soc; struct mutex lock;
@@ -447,23 +445,17 @@ static void exynos4412_tmu_initialize(struct platform_device *pdev) unsigned int trim_info, ctrl; if (data->soc == SOC_ARCH_EXYNOS3250 || - data->soc == SOC_ARCH_EXYNOS4412 || data->soc == SOC_ARCH_EXYNOS5250) { - if (data->soc == SOC_ARCH_EXYNOS3250) { - ctrl = readl(data->base + EXYNOS_TMU_TRIMINFO_CON1); - ctrl |= EXYNOS_TRIMINFO_RELOAD_ENABLE; - writel(ctrl, data->base + EXYNOS_TMU_TRIMINFO_CON1); - } + ctrl = readl(data->base + EXYNOS_TMU_TRIMINFO_CON1); + ctrl |= EXYNOS_TRIMINFO_RELOAD_ENABLE; + writel(ctrl, data->base + EXYNOS_TMU_TRIMINFO_CON1); + } else if (data->soc == SOC_ARCH_EXYNOS4412) { ctrl = readl(data->base + EXYNOS_TMU_TRIMINFO_CON2); ctrl |= EXYNOS_TRIMINFO_RELOAD_ENABLE; writel(ctrl, data->base + EXYNOS_TMU_TRIMINFO_CON2); } - /* On exynos5420 the triminfo register is in the shared space */ - if (data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) - trim_info = readl(data->base_second + EXYNOS_TMU_REG_TRIMINFO); - else - trim_info = readl(data->base + EXYNOS_TMU_REG_TRIMINFO); + trim_info = readl(data->base + EXYNOS_TMU_REG_TRIMINFO); sanitize_temp_error(data, trim_info); }
@@ -965,25 +957,6 @@ static int exynos_map_dt_data(struct platform_device *pdev) data->cal_type = TYPE_ONE_POINT_TRIMMING; - /* - * Check if the TMU shares some registers and then try to map the - * memory of common registers. - */ - if (data->soc != SOC_ARCH_EXYNOS5420_TRIMINFO) - return 0; - - if (of_address_to_resource(pdev->dev.of_node, 1, &res)) { - dev_err(&pdev->dev, "failed to get Resource 1\n"); - return -ENODEV; - } - - data->base_second = devm_ioremap(&pdev->dev, res.start, - resource_size(&res)); - if (!data->base_second) { - dev_err(&pdev->dev, "Failed to ioremap memory\n"); - return -ENOMEM; - } - return 0; }
--
2.55.0