Re: [PATCH v9 8/9] thermal/drivers/exynos: Add missing drvdata assignment in Exynos TMU probe

From
Anand Moon <hidden>
Date
2026-09-15 04:44:52
Also in
linux-pm, linux-samsung-soc, lkml
Reply to
Krzysztof Kozlowski, 2026-09-14
Hi Krzysztof,

Thanks for your review comments.
On Mon, 14 Sept 2026 at 12:31, Krzysztof Kozlowski [off-list ref] wrote:
On 13/09/2026 16:58, Anand Moon wrote:
quoted
Add dev_set_drvdata(&pdev->dev, data) early in the probe function,
ensuring that the driver data is properly registered and accessible
throughout the lifecycle of the device.

Signed-off-by: Anand Moon <redacted>
This is somehow confusing or completely incorrect code.

Either this was needed by the driver or not. If it was, then why no bug
is being described? If this was not needed, then you are doing no-op
changes.
I was looking into other SoCs that use this while debugging the
device-tree mapping issue,
so I initially tried adding it. If it is not required, I will drop this change.

Best regards,
Krzysztof
Thanks
-Anand
Thread (20 messages) 20 messages, 2 authors, last reply 2026-09-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help