Thread (21 messages) 21 messages, 4 authors, 1d ago

RE: [PATCH 04/13] arm64: dts: exynos8855: add cmu_top & cmu_peric clock DT nodes

From: "Alim Akhtar" <alim.akhtar@samsung.com>
Date: 2026-07-28 12:23:46
Also in: linux-clk, linux-devicetree, linux-samsung-soc, lkml

Hi Krzysztof,
-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Tuesday, July 28, 2026 5:30 PM
To: raghav.s <redacted>; s.nawrocki@samsung.com;
cw00.choi@samsung.com; peter.griffin@linaro.org;
alim.akhtar@samsung.com; mturquette@baylibre.com; sboyd@kernel.org;
bmasney@redhat.com; robh@kernel.org; conor+dt@kernel.org
Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org;
devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
kernel@vger.kernel.org; hajun.sung@samsung.com;
is.gandhi@samsung.com; ts.amit@samsung.com;
pokala.reddy@samsung.com
Subject: Re: [PATCH 04/13] arm64: dts: exynos8855: add cmu_top &
cmu_peric clock DT nodes

On 28/07/2026 14:11, raghav.s wrote:
quoted
Add required dt node for cmu_top & cmu_peric block

Signed-off-by: raghav.s <redacted>
---
 arch/arm64/boot/dts/exynos/exynos8855.dtsi | 24
++++++++++++++++++++++
 1 file changed, 24 insertions(+)
Please organize your patches in reasonable order. DTS is never in the middle,
see submitting patches (both documents) and maintainer-soc profile.
The thought was to add clks block wise and hence we see DTS coming in between but for the other blocks. 
e.g. patch-2 and 3 adds binding and driver for TOP and PERIC and this patch-4 adds DTS. 
And patch-5 and 6 adds binding and driver for PERIS and patch-7 adds DTS and so on.

Cover-letter should have explained this. 

Are you suggesting to re-order all the binding first followed by all blocks driver and then add a single DTS for all clock controller? 

Does current approach helps in review? 
Best regards,
Krzysztof
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help