Hi Janne,

Thank you again for your feedback!

On Sat, Jan 17, 2026 at 11:32 PM Janne Grunau [off-list ref] wrote:

On Thu, Jan 15, 2026 at 06:08:16PM +1100, Michael Reeves via B4 Relay wrote:

quoted

From: Michael Reeves <redacted>

Add the cell for the macsmc-power driver so it is probed by the
MFD core.

Co-developed-by: Hector Martin <redacted>
Signed-off-by: Hector Martin <redacted>

Co-developed-by: for a single line change as simple as this is silly.
Please just keep Hector as author and just add your SOB

Will fix in v4, thanks for pointing it out!

quoted

Reviewed-by: Neal Gompa <neal@gompa.dev>
Signed-off-by: Michael Reeves <redacted>
---
 drivers/mfd/macsmc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/macsmc.c b/drivers/mfd/macsmc.c
index 1b7e7b3e785f..358feec2d088 100644
--- a/drivers/mfd/macsmc.c
+++ b/drivers/mfd/macsmc.c

@@ -46,6 +46,7 @@

 static const struct mfd_cell apple_smc_devs[] = {
      MFD_CELL_NAME("macsmc-input"),
+     MFD_CELL_NAME("macsmc-power"),
      MFD_CELL_OF("macsmc-gpio", NULL, NULL, 0, 0, "apple,smc-gpio"),
      MFD_CELL_OF("macsmc-hwmon", NULL, NULL, 0, 0, "apple,smc-hwmon"),
      MFD_CELL_OF("macsmc-reboot", NULL, NULL, 0, 0, "apple,smc-reboot"),

This patch does not apply on top of v6.19-rc1. The base-commit helpfully
provided by b4 does not exists in my tree. I assume it's either a mfd or
linux-next commit? Please note the branch/tag this series applies to in
the cover letter if it is not the most recent -rc1 from Linus

It's based on-top of the latest linux-next, I will mention this in the
cover letter
body for v4 (i only put it in 'Changes in v3' for this one), thank you for the
pickup!

Janne

Thank you again!

Best regards,
Michael