Hi,


On 1/15/26 08:08, Michael Reeves via B4 Relay wrote:

From: Michael Reeves <redacted>

This driver provides battery and AC status monitoring for Apple Silicon
Macs via the SMC (System Management Controller). It supports
reporting capacity, voltage, current, and charging status.

Co-developed-by: Hector Martin <redacted>
Signed-off-by: Hector Martin <redacted>
Reviewed-by: Neal Gompa <neal@gompa.dev>
Signed-off-by: Michael Reeves <redacted>
---
  MAINTAINERS                         |   1 +
  drivers/power/supply/Kconfig        |  11 +
  drivers/power/supply/Makefile       |   1 +
  drivers/power/supply/macsmc-power.c | 834 ++++++++++++++++++++++++++++++++++++
  4 files changed, 847 insertions(+)

[...]

+
+static int macsmc_power_event(struct notifier_block *nb, unsigned long event, void *data)
+{
+	struct macsmc_power *power = container_of(nb, struct macsmc_power, nb);
+
+	/*
+	 * SMC Event IDs are reverse-engineered.

Any chance you meant something else here? The event IDs aren't special, 
everything here is reverse-engineered ;)
No need to change this imho unless there's another reason for a v4 though:

Reviewed-by: Sven Peter <sven@kernel.org>


Sven