Thread (11 messages) 11 messages, 5 authors, 2026-01-18

Re: [PATCH v3 1/2] power: supply: Add macsmc-power driver for Apple Silicon

From: Michael Reeves <hidden>
Date: 2026-01-18 12:53:57
Also in: asahi, linux-pm, lkml

Hi Sven,

Thank you so much for looking into this!

On Fri, Jan 16, 2026 at 8:00 AM Sven Peter [off-list ref] wrote:
[...]
quoted
+
+static int macsmc_power_event(struct notifier_block *nb, unsigned long event, void *data)
+{
+     struct macsmc_power *power = container_of(nb, struct macsmc_power, nb);
+
+     /*
+      * SMC Event IDs are reverse-engineered.
Any chance you meant something else here? The event IDs aren't special,
everything here is reverse-engineered ;)
I was more meaning that they are made by correlating when certain
event IDs appear,
so the comments I've added aren't 100% certain as what Apple intended
for each ID,
(unlike keys where we can be more certain because they report a
physical value).
I guess that wasn't the best choice of words as everything is RE'ed,
as you've said.
In v4 I'll make this clearer, thank you for the pickup.

Best regards,
Michael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help