On 9/25/2025 6:47 PM, Bjorn Andersson wrote:

On Wed, Sep 24, 2025 at 04:56:50PM -0700, Jingyi Wang wrote:

quoted

From: Taniya Das <redacted>

Support the graphics clock controller for Kaanapali for Graphics SW
driver to use the clocks.

GFXCLKCTL is a new thing, please describe what it is.

Sure Bjorn, will update more details of the GFXCLKCTL.

quoted

[..]

quoted

diff --git a/drivers/clk/qcom/gxclkctl-kaanapali.c b/drivers/clk/qcom/gxclkctl-kaanapali.c

[..]

quoted

+static struct platform_driver gx_clkctl_kaanapali_driver = {
+	.probe = gx_clkctl_kaanapali_probe,
+	.driver = {
+		.name = "gxclkctl-kaanapali",
+		.of_match_table = gx_clkctl_kaanapali_match_table,
+	},
+};
+
+static int __init gx_clkctl_kaanapali_init(void)
+{
+	return platform_driver_register(&gx_clkctl_kaanapali_driver);
+}
+subsys_initcall(gx_clkctl_kaanapali_init);

We're not starting up the GPU at subsys initlevel. Can't this just be
module_platform_driver()? If not please document why.

You are right, we could move it to module_platform_driver().

Regards,
Bjorn

quoted

+
+static void __exit gx_clkctl_kaanapali_exit(void)
+{
+	platform_driver_unregister(&gx_clkctl_kaanapali_driver);
+}
+module_exit(gx_clkctl_kaanapali_exit);
+
+MODULE_DESCRIPTION("QTI GFXCLKCTL KAANAPALI Driver");
+MODULE_LICENSE("GPL");

-- 
2.25.1

-- 
Thanks,
Taniya Das