On Thu, Sep 25, 2025 at 02:14:01PM +0530, Taniya Das wrote:

On 9/25/2025 1:59 PM, Bryan O'Donoghue wrote:

quoted

On 25/09/2025 00:56, Jingyi Wang wrote:

quoted

From: Taniya Das <redacted>

SC8280XP camcc only requires the MMCX power domain, unlike SM8450 camcc
which now supports both MMCX and MXC power domains. Hence move SC8280XP
camcc from SM8450.

Fixes: 842fa7482915 ("dt-bindings: clock: qcom,sm8450-camcc: Move
sc8280xp camcc to sa8775p camcc")
Signed-off-by: Taniya Das <redacted>
Signed-off-by: Jingyi Wang <redacted>
---
  Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 1 -
  1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-

camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-
camcc.yaml
index c1e06f39431e..dbfcc399f10b 100644

--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml

@@ -63,7 +63,6 @@ allOf:

          compatible:
            contains:
              enum:
-              - qcom,sc8280xp-camcc
                - qcom,sm8450-camcc
                - qcom,sm8550-camcc
      then:

This is not a revert.

Where does the compat string go ?

The compat is now part of
Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml as part
of this commit "842fa7482915".

quoted

You are missing the part where you move the compat string to where you
think it should be...

It was already moved as mentioned above.

I'm sorry, but I don't see where you say this. 

The commit message is a verbatim copy of the first paragraph of commit
'842fa7482915 ("dt-bindings: clock: qcom,sm8450-camcc: Move sc8280xp
camcc to sa8775p camcc")', where that comment makes sense. But here's
you're no longer moving something.

Please help me understand what I'm missing.

quoted

Also why is this patch appearing in a series about _adding_ Kanaapali to
CAMCC ?

This was to reduce less dependency on the series.

Had you sent this patch last week, I would have merged it into v6.18 and
there wouldn't have been any dependency.

Regards,
Bjorn

quoted

NAK

---
bod

-- 
Thanks,
Taniya Das