RE: [PATCH v6 08/10] PCI: imx6: Use dwc common suspend resume method

-----Original Message-----
From: Manivannan Sadhasivam <redacted>
Sent: 2024年11月23日 0:47
To: Hongxing Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de; bhelgaas@google.com; lpieralisi@kernel.org;
kw@linux.com; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
shawnguo@kernel.org; Frank Li [off-list ref]; s.hauer@pengutronix.de;
festevam@gmail.com; imx@lists.linux.dev; kernel@pengutronix.de;
linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 08/10] PCI: imx6: Use dwc common suspend resume
method

On Mon, Nov 18, 2024 at 03:00:44AM +0000, Hongxing Zhu wrote:

[...]

quoted

quoted

quoted

-static void imx_pcie_pm_turnoff(struct imx_pcie *imx_pcie) -{
-	struct device *dev = imx_pcie->pci->dev;
-
-	/* Some variants have a turnoff reset in DT */
-	if (imx_pcie->turnoff_reset) {
-		reset_control_assert(imx_pcie->turnoff_reset);
-		reset_control_deassert(imx_pcie->turnoff_reset);

Where these are handled in imx_pcie_pme_turn_off()? If you removed
them intentionally for a reason, it should be mentioned in commit

message.

quoted

quoted

How about add the following descriptions into commit message?
SRC interface is used to do the PME_TURN_OFF operations before. It's
not very

What is SRC?

SRC is System Reset Control.

quoted

 suitable. Now DWC common driver can do the PME_TURN_OFF kick off.
Switch to  this common methods, and remove the useless turnoff_reset

manipulate codes.

quoted

Hmm, so 'turnoff_reset' is used to send PME_Turn_Off msg?

Yes, it is.

If so, then you need to say in such a way that the reader should understand
'turnoff_reset' was used to send PME_Turn_Off and since the DWC
implementation is used, it is not needed now.

Okay. Thanks.

Best Regards
Richard Zhu

- Mani

--
மணிவண்ணன் சதாசிவம்