Re: [PATCH v6 04/10] PCI: imx6: Correct controller_id generation logic for i.MX7D
From: Manivannan Sadhasivam <hidden>
Date: 2024-11-15 06:43:32
Also in:
imx, linux-devicetree, linux-pci, lkml
On Fri, Nov 01, 2024 at 03:06:04PM +0800, Richard Zhu wrote:
i.MX7D only has one PCIe controller, so controller_id should always be 0. The previous code is incorrect although yielding the correct result. Fix by removing IMX7D from the switch case branch.
Worth adding a fixes tag?
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Manivannan Sadhasivam <redacted>
Reviewed-by: Frank Li <Frank.Li@nxp.com> --- "This is just *wrong*. You cannot hardcode the MMIO address in the driver. Even though this code is old, you should fix it instead of building on top of it. - Mani" IMX7D here is wrong athough check IMX8MQ_PCIE2_BASE_ADDR is not good method. Previously try to use 'linux,pci-domain' to replace this check logic. Need more discussion to improve it and keep old compatiblity. Let's fix this code error firstly.
I really hope that you'll fix it asap. - Mani
quoted hunk ↗ jump to hunk
--- drivers/pci/controller/dwc/pci-imx6.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 462decd1d589..996333e9017d 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c@@ -1342,7 +1342,6 @@ static int imx_pcie_probe(struct platform_device *pdev) switch (imx_pcie->drvdata->variant) { case IMX8MQ: case IMX8MQ_EP: - case IMX7D: if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) imx_pcie->controller_id = 1; break;-- 2.37.1
-- மணிவண்ணன் சதாசிவம்