Re: [PATCH v6 05/10] PCI: imx6: Make core reset assertion deassertion symmetric

On Mon, Nov 18, 2024 at 02:59:59AM +0000, Hongxing Zhu wrote:

quoted

-----Original Message-----
From: Manivannan Sadhasivam <redacted>
Sent: 2024年11月15日 14:52
To: Hongxing Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de; bhelgaas@google.com; lpieralisi@kernel.org;
kw@linux.com; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
shawnguo@kernel.org; Frank Li [off-list ref];
s.hauer@pengutronix.de; festevam@gmail.com; imx@lists.linux.dev;
kernel@pengutronix.de; linux-pci@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 05/10] PCI: imx6: Make core reset assertion
deassertion symmetric

On Fri, Nov 01, 2024 at 03:06:05PM +0800, Richard Zhu wrote:

quoted

Add apps_reset deassertion in the imx_pcie_deassert_core_reset(). Let
it be symmetric with imx_pcie_assert_core_reset().

In the commit first introduced apps_reset, apps_reset is asserted in
imx6_pcie_assert_core_reset(), but it is de-asserted in another place,
in

I'd suggest rewording like below to make it easy to understand,

"PCI: imx6: Deassert apps_reset in imx_pcie_assert_core_reset()

I'm very appreciate for your rewords. Should the imx_pcie_assert_core_reset()
 be imx_pcie_deassert_core_reset()?

Yeah!

- Mani

-- 
மணிவண்ணன் சதாசிவம்