-----Original Message-----
From: Manivannan Sadhasivam <redacted>
Sent: 2024年11月15日 14:52
To: Hongxing Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de; bhelgaas@google.com; lpieralisi@kernel.org;
kw@linux.com; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
shawnguo@kernel.org; Frank Li [off-list ref];
s.hauer@pengutronix.de; festevam@gmail.com; imx@lists.linux.dev;
kernel@pengutronix.de; linux-pci@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 05/10] PCI: imx6: Make core reset assertion
deassertion symmetric

On Fri, Nov 01, 2024 at 03:06:05PM +0800, Richard Zhu wrote:

quoted

Add apps_reset deassertion in the imx_pcie_deassert_core_reset(). Let
it be symmetric with imx_pcie_assert_core_reset().

In the commit first introduced apps_reset, apps_reset is asserted in
imx6_pcie_assert_core_reset(), but it is de-asserted in another place,
in

I'd suggest rewording like below to make it easy to understand,

"PCI: imx6: Deassert apps_reset in imx_pcie_assert_core_reset()

I'm very appreciate for your rewords. Should the imx_pcie_assert_core_reset()
 be imx_pcie_deassert_core_reset()?

Best Regards
Richard Zhu

Since the apps_reset is asserted in imx_pcie_assert_core_reset(), it should be
deasserted in imx_pcie_deassert_core_reset()."

quoted

stead of the according symmetric function

imx6_pcie_deassert_core_reset().

quoted

Use this patch to fix it, and make core reset assertion deasertion
symmetric.

Fixes: 9b3fe6796d7c ("PCI: imx6: Add code to support i.MX7D")
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>

With above change,

Reviewed-by: Manivannan Sadhasivam
[off-list ref]

- Mani

quoted

Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/pci/controller/dwc/pci-imx6.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c

b/drivers/pci/controller/dwc/pci-imx6.c
index 996333e9017d..54039d2760d5 100644

--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c

@@ -772,6 +772,7 @@ static void imx_pcie_assert_core_reset(struct

imx_pcie *imx_pcie)  static int imx_pcie_deassert_core_reset(struct
imx_pcie *imx_pcie)  {
 	reset_control_deassert(imx_pcie->pciephy_reset);
+	reset_control_deassert(imx_pcie->apps_reset);

 	if (imx_pcie->drvdata->core_reset)
 		imx_pcie->drvdata->core_reset(imx_pcie, false);
--
2.37.1

--
மணிவண்ணன் சதாசிவம்