[AMD Official Use Only - General]

-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org>
Sent: Tuesday, January 17, 2023 7:40 PM
To: Gupta, Nipun <Nipun.Gupta@amd.com>
Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; rafael@kernel.org;
eric.auger@redhat.com; alex.williamson@redhat.com; cohuck@redhat.com;
song.bao.hua@hisilicon.com; mchehab+huawei@kernel.org; maz@kernel.org;
f.fainelli@gmail.com; jeffrey.l.hugo@gmail.com; saravanak@google.com;
Michael.Srba@seznam.cz; mani@kernel.org; yishaih@nvidia.com;
jgg@ziepe.ca; jgg@nvidia.com; robin.murphy@arm.com; will@kernel.org;
joro@8bytes.org; masahiroy@kernel.org; ndesaulniers@google.com; linux-arm-
kernel@lists.infradead.org; linux-kbuild@vger.kernel.org; linux-
kernel@vger.kernel.org; devicetree@vger.kernel.org; okaya@kernel.org;
Anand, Harpreet [off-list ref]; Agarwal, Nikhil
[off-list ref]; Simek, Michal [off-list ref]; git
(AMD-Xilinx) [off-list ref]
Subject: Re: [PATCH 05/19] bus/cdx: add cdx controller

Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.


On Tue, Jan 17, 2023 at 07:11:37PM +0530, Nipun Gupta wrote:

quoted

--- /dev/null
+++ b/drivers/bus/cdx/controller/cdx_controller.c

@@ -0,0 +1,243 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Platform driver for CDX bus controller.

Why is this a platform driver?  Shouldn't it also be on some type of bus
so that you can find it?

This is host controller for CDX bus similar to PCI controller which is also on
the platform bus.
Since CDX bus controller is based on communication with RPU firmware we
need to have references to remoteproc device in CDX controller node to use
the RPMsg device.

quoted

+MODULE_VERSION("1.0");

There's never need for any module versions once the code is in the
kernel tree as then they make no sense at all.  Please drop them from
this series.

Sure. Will remove.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel