Re: [PATCH 05/19] bus/cdx: add cdx controller
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2023-01-17 14:10:29
Also in:
linux-devicetree, linux-kbuild, lkml
On Tue, Jan 17, 2023 at 07:11:37PM +0530, Nipun Gupta wrote:
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/bus/cdx/controller/cdx_controller.c@@ -0,0 +1,243 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Platform driver for CDX bus controller.
Why is this a platform driver? Shouldn't it also be on some type of bus so that you can find it?
+MODULE_VERSION("1.0");There's never need for any module versions once the code is in the kernel tree as then they make no sense at all. Please drop them from this series. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel