On 5/10/2022 7:57 am, Sebastian Reichel wrote:

Hi,

On Tue, Oct 04, 2022 at 05:19:11PM +0200, Frank Wunderlich wrote:

quoted

Am 4. Oktober 2022 17:09:29 MESZ schrieb Rob Herring [off-list ref]:

quoted

On Thu, Aug 25, 2022 at 09:38:32PM +0200, Frank Wunderlich wrote:

quoted

From: Frank Wunderlich <redacted>

quoted

quoted

+properties:
+  compatible:
+    enum:
+      - rockchip,rk3568-pcie3-phy

The driver also has 'rockchip,rk3588-pcie3-phy'. Please send a fix 
adding it here or removing from the driver. Are they not compatible with 
each other?

Right, original driver has rk3588 support,but we can't test it.
Initialization and lane-mapping (bifurcation) was bit different.
So we wanted to upstream rk3568 first (but have not removed this
part from driver).

I see that someone added rk3588 basic support and if he can test
rk3588 i can send compatible for it.

Basic rk3588 support is still WIP. At the moment patches for the CRU
are still pending as well as base DT. I hope to land them for v6.2
(so next merge window). At the same time I don't think PCIe support
is realistic before v6.3.

Hi all,

I can confirm this patchset successfully brings up the PCIe 3.0
controller/PHY on an RK3588 - I'm using a Pine64 QuartzPro64, which is
very similar to the Rockchip RK3588-EVB1 board. Runs fine at x1, x2, x4
lane widths and full 8GT/s lane throughput.

The PCIe 2.0 lanes (which use the same PCIe controller driver) need some
changes to the rockchip-naneng-combphy driver that I've not quite gotten
to a working state, but that's unrelated to this series.

I have a (very messy) tree based on v6.0 (on GitHub at [0]) with
Sebastian's other RK3588 support patches dropped in, along with this
series and a few other tweaks. Works quite well :)

So insofar as RK3588 support is concerned,

Tested-By: Andrew Powers-Holmes <redacted>

[0] https://github.com/neggles/linux-quartz64/tree/qp64-pcie

Cheers,
A

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel