Thread (37 messages) 37 messages, 3 authors, 2022-10-24

Re: [PATCH V3 5/6] arm64: dts: meson: add S4 Soc Peripheral clock controller in DT

From: Krzysztof Kozlowski <hidden>
Date: 2022-08-08 06:17:25
Also in: linux-amlogic, linux-clk, linux-devicetree, lkml

On 05/08/2022 11:36, Yu Tu wrote:
quoted
quoted
@@ -100,6 +102,30 @@ clkc_pll: pll-clock-controller@8000 {
  				#clock-cells = <1>;
  			};
  
+			clkc_periphs: periphs-clock-controller {
Node names should be generic, so "clock-controller"
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

You miss here unit address. Test your DTS with dtbs check and with
regular compile with W=1.
I will change to clkc_periphs: clock-controller@0 {.
Is that okay?
I cut the context, so if "0" was the value in reg, then it is OK.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help