Re: [PATCH 2/8] serial: core, 8250: set RS485 termination gpio in serial core
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Date: 2022-06-23 02:04:16
Also in:
linux-devicetree, linux-serial, lkml
On 22.06.22 at 19:06, Andy Shevchenko wrote:
On Wed, Jun 22, 2022 at 05:46:53PM +0200, Lino Sanfilippo wrote:quoted
From: Lino Sanfilippo <redacted> In serial8250_em485_config() the termination GPIO is set with the uart_port spinlock held. This is an issue if setting the GPIO line can sleep (e.g. since the concerning GPIO expander is connected via SPI or I2C). Fix this by setting the termination line outside of the uart_port spinlock in the serial core.This doesn't describe that this patch is actually changing GPIO to support sleep mode. So, it doesn't fix anything. Please rephrase the commit message accordingly.
Good point, I will adjust the commit message in the next version.
quoted
This also makes setting the termination GPIO generic for all uart drivers.UART
Right, upper letters should be used. Thanks a lot for the review! Regards, Lino _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel