Re: [PATCH] PCI: Marvell: Update PCIe fixup
From: Pali Rohár <pali@kernel.org>
Date: 2021-11-01 17:57:31
Also in:
linux-mips, linux-pci, lkml
On Monday 01 November 2021 13:27:11 Jason Gunthorpe wrote:
On Mon, Nov 01, 2021 at 04:04:05PM +0100, Pali Rohár wrote:quoted
- The code relies on rc_pci_fixup being called, which only happens when CONFIG_PCI_QUIRKS is enabled, so add that to Kconfig. Omitting this causes a booting failure with a non-obvious cause. - Update rc_pci_fixup to set the class properly, copying the more modern style from other places - Correct the rc_pci_fixup comment This patch just re-applies commit 1dc831bf53fd ("ARM: Kirkwood: Update PCI-E fixup") for all other Marvell platforms which use same buggy PCIe controller.I wonder if that code is even relevant any more since we started using CONFIG_PCI_MVEBU ?
It is (still) relevant for platforms which do not use CONFIG_PCI_MVEBU yet.
Really, these broken controllers should not be used "raw" but always via their special host bridge driver that fixes all the config space problems.
I agree. Long-term goal should be to convert these platforms to use pci-mvebu.c driver. And until it happens simple fixes like in commit 1dc831bf53fd is needed for all affected Marvell platforms. Some details how these Marvell PCIe controllers are broken is in email: https://lore.kernel.org/linux-pci/20211003120944.3lmwxylnhlp2kfj7@pali/ (local) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel