Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id

On Wed, Sep 01, 2021 at 05:31:32PM +0200, Jernej Škrabec wrote:

Dne torek, 31. avgust 2021 ob 22:53:24 CEST je Andrew Lunn napisal(a):

quoted

quoted

True, but then again, DT is a bit special, since it's not used only by 

Linux. 

quoted

quoted

It's shared at least with BSDs and U-Boot, which most likely have 

independent 

quoted

quoted

driver implementation. That's why it's good to have DT fixes referencing DT 
related commits. As you said, DT described HW wrong.

Looking at past Allwinner related DT commits regarding this issue, we were 

not 

quoted

quoted

totally consistent. Most of them reference commit where emac node was 
introduced in DT. But I also found a couple of commits which indeed have 

fixes 

quoted

quoted

tag for bbc4d71d6354.

All true, and it is not a big deal if it does go back further. I don't
care, we can let the Allwinner Maintainer decide. Ah, that is you :-)

I just want to try to keep it simple for somebody who is contributing
their first Linux kernel patch. If it is good enough, i say accept it,
and we can do a bit more education on the second contribution.

Maxime, Chen-Yu, thoughts?

Since there are both approaches for fixes tag already in, I guess this is also 
fine.

I agree with you, the fixes should point at the initial Device Tree
issue. Our DT are used by other projects and even if in Linux it wasn't
causing any issue before another commit showed up, it might affect those
projects differently.

Maxime