Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
From: Jernej Škrabec <jernej.skrabec@gmail.com>
Date: 2021-08-30 20:49:44
Also in:
linux-sunxi, lkml
Hi! Dne ponedeljek, 30. avgust 2021 ob 17:16:45 CEST je Clément Bœsch napisal(a):
Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
config") network is broken on the NanoPi Neo 2.
This patch changes the phy-mode to use internal delays both for RX and
TX as has been done for other boards affected by the same commit.
Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
This commit fixes DT issue, so "fixes" tag should be:
Fixes: 44a94c7ef989 ("arm64: dts: allwinner: H5: Restore EMAC changes")
Here, a node with wrong phy-mode property was added to NanoPi Neo 2 board DT.
Other than that, this patch is fine and once fixes tag is fixed, you can add:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
For next version, you should:
- change fixed tag
- add my review-by tag right above your signed-off-by tag
- mark patch as v2 (add "-v2" parameter to git format-patch)
- describe change right under "---" line
Note, if you borked something when sending, you should mark patch or patch
series as "RESEND", so recipients don't look for changes in two subsequent e-
mails (--subject-prefix="RESEND PATCH").
Thanks for the fix!
Best regards,
Jernej
quoted hunk ↗ jump to hunk
Signed-off-by: Clément Bœsch <redacted> --- arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dtsb/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts index 02f8e72f0cad..05486cccee1c 100644--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts@@ -75,7 +75,7 @@ &emac { pinctrl-0 = <&emac_rgmii_pins>; phy-supply = <®_gmac_3v3>; phy-handle = <&ext_rgmii_phy>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; status = "okay"; };
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel