Re: Re: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
From: Jernej Škrabec <jernej.skrabec@gmail.com>
Date: 2021-09-01 15:31:41
Also in:
linux-sunxi, lkml
Dne torek, 31. avgust 2021 ob 22:53:24 CEST je Andrew Lunn napisal(a):
quoted
True, but then again, DT is a bit special, since it's not used only by
Linux.
quoted
It's shared at least with BSDs and U-Boot, which most likely have
independent
quoted
driver implementation. That's why it's good to have DT fixes referencing DT related commits. As you said, DT described HW wrong. Looking at past Allwinner related DT commits regarding this issue, we were
not
quoted
totally consistent. Most of them reference commit where emac node was introduced in DT. But I also found a couple of commits which indeed have
fixes
quoted
tag for bbc4d71d6354.All true, and it is not a big deal if it does go back further. I don't care, we can let the Allwinner Maintainer decide. Ah, that is you :-) I just want to try to keep it simple for somebody who is contributing their first Linux kernel patch. If it is good enough, i say accept it, and we can do a bit more education on the second contribution.
Maxime, Chen-Yu, thoughts? Since there are both approaches for fixes tag already in, I guess this is also fine. Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel