Thread (51 messages) 51 messages, 9 authors, 2021-10-14

Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control

From: Brad Larson <hidden>
Date: 2021-08-23 01:08:04
Also in: linux-devicetree, linux-gpio, linux-mmc, linux-spi, lkml

Hi Krzysztof,

On Fri, Mar 5, 2021 at 3:25 AM Krzysztof Kozlowski
[off-list ref] wrote:
On 04/03/2021 04:41, Brad Larson wrote:
quoted
This GPIO driver is for the Pensando Elba SoC which
provides control of four chip selects on two SPI busses.
[...]
quoted
+     ret = devm_gpiochip_add_data(&pdev->dev, &p->chip, p);
+     if (ret) {
+             dev_err(&pdev->dev, "unable to add gpio chip\n");
+             return ret;
+     }
+
+     dev_info(&pdev->dev, "elba spics registered\n");
Don't print trivial probe results, unless you print here something
useful. If you need it for debugging, keep it dev_dbg.
Removed that extraneous logging

Regards,
Brad

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help