RE: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control
From: Elliott, Robert (Servers) <hidden>
Date: 2021-03-04 20:45:58
Also in:
linux-devicetree, linux-gpio, linux-mmc, linux-spi, lkml
-----Original Message----- From: Brad Larson <redacted> Sent: Wednesday, March 3, 2021 9:42 PM Subject: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control
.
quoted hunk ↗ jump to hunk
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
...
+config GPIO_ELBA_SPICS + bool "Pensando Elba SPI chip-select" + depends on ARCH_PENSANDO_ELBA_SOC + help + Say yes here to support the Pensndo Elba SoC SPI chip-select driver
Pensndo should be Pensando
quoted hunk ↗ jump to hunk
diff --git a/drivers/gpio/gpio-elba-spics.c b/drivers/gpio/gpio-elba-spics.c + * Pensando Elba ASIC SPI chip select driver
...
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Elba SPI chip-select driver");I think it's conventional to include the company name there, so start that with "Pensando Elba" Also, "SoC" and "ASIC" are sometimes included after Elba, but sometimes are not. Consistency might be helpful.
+static const struct of_device_id ebla_spics_of_match[] = {...
+ .of_match_table = ebla_spics_of_match,
ebla should be elba _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel