Re: [PATCH v2 4/8] drivers/perf: hisi: Add new functions for HHA PMU

Hi Mark,

在 2021/2/3 21:18, Mark Rutland 写道:

On Wed, Feb 03, 2021 at 03:51:04PM +0800, Shaokun Zhang wrote:

quoted

On HiSilicon Hip09 platform, some new functions are also supported on
HHA PMU, it can filter gathered statistics by the Master ID and mask
from the SoC if the user wants to do deep-going profiling.
Tracetag support is also added with L3C PMU in the SoC system.

$# perf stat -a -e hisi_sccl3_hha0/config=0x02,tracetag_en=0x1/ sleep 5

$# perf stat -a -e hisi_sccl3_hha0/config=0x02,srcid_cmd=0x1/ sleep 5

Much more introduction is added in documentation:
Documentation/admin-guide/perf/hisi-pmu.rst

Could we please enumerate the relevant fields here, with a brief
description? From a quick scan these are different to those added fo
rthe L3C PMU.

Apologies that the bad commit log is confused and I will update the
the fields description in next version.

I appreciate the last partch in the series adds some documentation, but
it'd be nice to have the context where it's needed.

[...]

quoted

@@ -193,6 +304,22 @@ static int hisi_hha_pmu_init_data(struct platform_device *pdev,
 		dev_err(&pdev->dev, "Can not read hha sccl-id!\n");
 		return -EINVAL;
 	}
+
+	/*
+	 * Early versions of BIOS support _UID by mistake, so we support
+	 * both "hisilicon, idx-id" as preference, if availbale.

Typo: s/availbale/available/

Ok.

Thanks,
Shaokun

Thanks,
Mark.
.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel