Re: [PATCH v2 3/8] drivers/perf: hisi: Add new functions for L3C PMU
From: Mark Rutland <mark.rutland@arm.com>
Date: 2021-02-03 13:11:31
On Wed, Feb 03, 2021 at 03:51:03PM +0800, Shaokun Zhang wrote:
On HiSilicon Hip09 platform, some new functions are enhanced on L3C PMU, like, tracetag feature that L3C PMU can only count the specified operations by the user, or L3C PMU can give the desired core's statistics in the cluster. $# perf stat -a -e hisi_sccl3_l3c0/config=0x02,tt_core=0xf/ sleep 5 $# perf stat -a -e hisi_sccl3_l3c0/config=0x02,tt_req=0x4/ sleep 5
Are these values documented somewhere? [...]
+HISI_PMU_EVENT_ATTR_EXTRACTOR(tt_core, config1, 7, 0); +HISI_PMU_EVENT_ATTR_EXTRACTOR(tt_req, config1, 10, 8); +HISI_PMU_EVENT_ATTR_EXTRACTOR(datasrc_cfg, config1, 15, 11); +HISI_PMU_EVENT_ATTR_EXTRACTOR(datasrc_skt, config1, 16, 16);
Could you please mention all of these in the commit message? IIUC tt_core is a mask of physical cores in the cluster, and I guess tt_req is a request type, but I have no idea what the datasrc_cfg or datasrc_skt (socket?) fields represent. A rough description would be very helpful, something like: | We expose the tracetag filters with new fields exposed to userspace: | | * tt_core is a mask of cores within the PMU's cluster | * tt_req is ??? | * datasrc_cfg is ??? | * datasrc_skt is ??? Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel