Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value
From: Tomasz Figa <tfiga@chromium.org>
Date: 2020-08-22 14:54:40
Also in:
linux-samsung-soc, linux-spi, lkml
Possibly related (same subject, not in this thread)
- 2020-08-25 · Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value · Lukasz Stelmach <l.stelmach@samsung.com>
- 2020-08-25 · Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value · Tomasz Figa <tfiga@chromium.org>
- 2020-08-25 · Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value · Lukasz Stelmach <l.stelmach@samsung.com>
- 2020-08-24 · Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value · Tomasz Figa <tfiga@chromium.org>
- 2020-08-24 · Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value · Lukasz Stelmach <l.stelmach@samsung.com>
On Fri, Aug 21, 2020 at 6:14 PM Łukasz Stelmach [off-list ref] wrote:
cur_speed is used to calculate transfer timeout and needs to be set to the actual value of (half) the clock speed for precise calculations. Cc: Tomasz Figa <tfiga@chromium.org>
As we talked on IRC, Lukasz forgot to add: Suggested-by: Tomasz Figa <redacted> Would be nice if it could be added when (and if) applying.
quoted hunk ↗ jump to hunk
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 02de734b8ab1..89c162efe355 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c@@ -626,6 +626,7 @@ static int s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd) ret = clk_set_rate(sdd->src_clk, sdd->cur_speed * 2); if (ret) return ret; + sdd->cur_speed = clk_get_rate(sdd->src_clk) / 2; } else { /* Configure Clock */ val = readl(regs + S3C64XX_SPI_CLK_CFG); --2.26.2
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel