Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values
From: Sylwester Nawrocki <snawrocki@kernel.org>
Date: 2020-08-25 19:06:17
Also in:
linux-samsung-soc, linux-spi, lkml
Possibly related (same subject, not in this thread)
- 2020-09-03 · Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values · Sylwester Nawrocki <snawrocki@kernel.org>
- 2020-09-03 · Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values · Lukasz Stelmach <l.stelmach@samsung.com>
- 2020-09-02 · Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values · Sylwester Nawrocki <snawrocki@kernel.org>
- 2020-09-01 · Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values · Lukasz Stelmach <l.stelmach@samsung.com>
On 8/21/20 18:13, Łukasz Stelmach wrote:
Check return values in prepare_dma() and s3c64xx_spi_config() and propagate errors upwards. Signed-off-by: Łukasz Stelmach<l.stelmach@samsung.com> --- drivers/spi/spi-s3c64xx.c | 47 ++++++++++++++++++++++++++++++++------- 1 file changed, 39 insertions(+), 8 deletions(-)
quoted hunk ↗ jump to hunk
@@ -298,12 +299,24 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma, desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents, dma->direction, DMA_PREP_INTERRUPT); + if (!desc) { + dev_err(&sdd->pdev->dev, "unable to prepare %s scatterlist", + dma->direction == DMA_DEV_TO_MEM ? "rx" : "tx"); + return -ENOMEM; + } desc->callback = s3c64xx_spi_dmacb; desc->callback_param = dma; dma->cookie = dmaengine_submit(desc); + ret = dma_submit_error(dma->cookie); + if (ret) { + dev_err(&sdd->pdev->dev, "DMA submission failed"); + return -EIO;
Just return the error value from dma_submit_error() here? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel