Re: [PATCH 09/13] cpufreq: acpi-cpufreq: Remove unused ID structs
From: Lee Jones <hidden>
Date: 2020-07-15 06:37:13
Also in:
linux-pm, lkml
On Wed, 15 Jul 2020, Viresh Kumar wrote:
On 15-07-20, 08:54, Viresh Kumar wrote:quoted
On 14-07-20, 22:03, Lee Jones wrote:quoted
On Tue, 14 Jul 2020, Rafael J. Wysocki wrote:quoted
On Tue, Jul 14, 2020 at 4:51 PM Lee Jones [off-list ref] wrote:quoted
Can't see them being used anywhere and the compiler doesn't complain that they're missing, so ...Aren't they needed for automatic module loading in certain configurations?Any idea how that works, or where the code is for that?The MODULE_DEVICE_TABLE() thingy creates a map of vendor-id, product-id that the kernel keeps after boot (and so there is no static reference of it for the compiler), later when a device is hotplugged into the kernel it refers to the map to find the related driver for it and loads it if it isn't already loaded. This has some of it, search for MODULE_DEVICE_TABLE() in it. Documentation/driver-api/usb/hotplug.rstAnd you just need to add __maybe_unused to them to suppress the warning.
Right. That's Plan B. Will fix. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel