Thread (68 messages) flat view 68 messages, 6 authors, 2020-07-15

Re: [PATCH 11/13] cpufreq: pcc-cpufreq: Remove unused ID structs

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2020-07-14 17:42:56
Also in: linux-pm, lkml

On Tue, Jul 14, 2020 at 4:51 PM Lee Jones [off-list ref] wrote:
Can't see them being used anywhere and the compiler doesn't complain
that they're missing, so ...
Autoloading of the module too.
quoted hunk ↗ jump to hunk
Fixes the following W=1 kernel build warning(s):

 drivers/cpufreq/pcc-cpufreq.c:619:36: warning: ‘processor_device_ids’ defined but not used [-Wunused-const-variable=]
 619 | static const struct acpi_device_id processor_device_ids[] = {
 | ^~~~~~~~~~~~~~~~~~~~

Cc: Matthew Garrett <redacted>
Cc: Nagananda Chumbalkar <redacted>
Signed-off-by: Lee Jones <redacted>
---
 drivers/cpufreq/pcc-cpufreq.c | 7 -------
 1 file changed, 7 deletions(-)
diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
index 5789fe7a94bd3..99cf8b78c032a 100644
--- a/drivers/cpufreq/pcc-cpufreq.c
+++ b/drivers/cpufreq/pcc-cpufreq.c
@@ -616,13 +616,6 @@ static void __exit pcc_cpufreq_exit(void)
        free_percpu(pcc_cpu_info);
 }

-static const struct acpi_device_id processor_device_ids[] = {
-       {ACPI_PROCESSOR_OBJECT_HID, },
-       {ACPI_PROCESSOR_DEVICE_HID, },
-       {},
-};
-MODULE_DEVICE_TABLE(acpi, processor_device_ids);
-
 MODULE_AUTHOR("Matthew Garrett, Naga Chumbalkar");
 MODULE_VERSION(PCC_VERSION);
 MODULE_DESCRIPTION("Processor Clocking Control interface driver");
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help