On Wed, Jun 12, 2019 at 11:34:51AM +0000, Z.q. Hou wrote:

Hi Lorenzo,

Thanks a lot for your comments!

quoted

-----Original Message-----
From: Lorenzo Pieralisi <redacted>
Sent: 2019年6月12日 1:00
To: Z.q. Hou <zhiqiang.hou@nxp.com>
Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
bhelgaas@google.com; robh+dt@kernel.org; mark.rutland@arm.com;
l.subrahmanya@mobiveil.co.in; shawnguo@kernel.org; Leo Li
[off-list ref]; catalin.marinas@arm.com; will.deacon@arm.com;
Mingkai Hu [off-list ref]; M.h. Lian [off-list ref];
Xiaowei Bao [off-list ref]
Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag
MSI_FLAG_MULTI_PCI_MSI

On Fri, Apr 12, 2019 at 08:35:36AM +0000, Z.q. Hou wrote:

quoted

From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

The current code does not support multiple MSIs, so remove the
corresponding flag from the msi_domain_info structure.

Please explain me what's the problem before removing multi MSI support.

NXP LX2 PCIe use the GIC-ITS instead of Mobiveil IP internal MSI
controller, so, I didn't encounter problem.

Well, you sent a patch to fix an issue, explain me the issue you
are fixing then, aka what have you sent this patch for ?

Lorenzo

Subbu, did you test with Endpoint supporting multi MSI?

Thanks,
Zhiqiang

quoted

Thanks,
Lorenzo

quoted

Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support")
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
---
V5:
 - Corrected the subject.

 drivers/pci/controller/pcie-mobiveil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-mobiveil.c

b/drivers/pci/controller/pcie-mobiveil.c
index 563210e731d3..a0dd337c6214 100644

--- a/drivers/pci/controller/pcie-mobiveil.c
+++ b/drivers/pci/controller/pcie-mobiveil.c

@@ -703,7 +703,7 @@ static struct irq_chip mobiveil_msi_irq_chip = {

 static struct msi_domain_info mobiveil_msi_domain_info = {
 	.flags	= (MSI_FLAG_USE_DEF_DOM_OPS |

MSI_FLAG_USE_DEF_CHIP_OPS |

quoted

-		   MSI_FLAG_MULTI_PCI_MSI | MSI_FLAG_PCI_MSIX),
+		   MSI_FLAG_PCI_MSIX),
 	.chip	= &mobiveil_msi_irq_chip,
 };

--
2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel