Thread (59 messages) 59 messages, 9 authors, 2019-03-01

Re: [RFC][PATCH] objtool: STAC/CLAC validation

flat view

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2019-02-23 01:41:33

On Fri, Feb 22, 2019 at 5:17 PM Andy Lutomirski [off-list ref] wrote:
I don't have commit access :)  But I shall email it out once I test it a bit.
Btw, looking at it, with that change every user of __put_user_size()
now passes in the properly type-cast value in 'x'.

Which means that you could remove the odd typecast in the 8-byte case:

        case 8:                                                         \
                __put_user_goto_u64((__typeof__(*ptr))(x), ptr, label); \

and make it match all the other cases:

        case 8:                                                         \
                __put_user_goto_u64(x, ptr, label);                     \

but that's just from looking at the patch, and maybe I'm missing something.

                  Linus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help