Re: [PATCH] sched/x86: Save [ER]FLAGS on context switch
flat view
From: Andy Lutomirski <luto@amacapital.net>
Date: 2019-02-15 18:28:13
Also in:
lkml
On Feb 15, 2019, at 9:40 AM, Peter Zijlstra [off-list ref] wrote:quoted
On Fri, Feb 15, 2019 at 09:18:00AM -0800, Linus Torvalds wrote:quoted
On Thu, Feb 14, 2019 at 11:34 AM Peter Zijlstra [off-list ref] wrote: Something like the below, right? + frame->flags = 0; + frame->flags = 0;Those are not valid flag values. Can you popf them? Yes. Do they make sense? No. It has the IF flag clear, for example. Is that intentional? If it is,Uhmm. yeah, that's bonkers. We should have interrupts disabled here. I'll go read up on the eflags and figure out what they _should_ be right about there.
And probably add a comment near the POPF explaining that it will keep IRQs off :) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel