Re: [PATCH] sched/x86: Save [ER]FLAGS on context switch
flat view
From: Andy Lutomirski <luto@amacapital.net>
Date: 2019-02-19 02:20:12
Also in:
lkml
On Feb 18, 2019, at 4:24 PM, Linus Torvalds [off-list ref] wrote:quoted
On Mon, Feb 18, 2019 at 2:31 PM H. Peter Anvin [off-list ref] wrote: The question is what "fix it" means. I'm really concerned about AC escapes, and everyone else should be, too.I do think that it might be the right thing to do to add some kind of WARN_ON_ONCE() for AC being set in various can-reschedule situations. We'd just have to abstract it sanely. I'm sure arm64 has the exact same issue with PAN - maybe it saves properly, but the same "we wouldn't want to go through the scheduler with PAN clear". On x86, we might as well check DF at the same time as AC.
hpa is right, though — calling into tracing code with AC set is not really so good. And calling schedule() (via preempt_enable() or whatever) is also bad because it runs all the scheduler code with AC on. Admittedly, the scheduler is not *that* interesting of an attack surface. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel