Re: [PATCH] sched/x86: Save [ER]FLAGS on context switch
flat view
From: Peter Zijlstra <peterz@infradead.org>
Date: 2019-02-19 09:19:34
Also in:
lkml
On Tue, Feb 19, 2019 at 10:15:25AM +0100, Peter Zijlstra wrote:
On Mon, Feb 18, 2019 at 04:24:30PM -0800, Linus Torvalds wrote:quoted
On Mon, Feb 18, 2019 at 2:31 PM H. Peter Anvin [off-list ref] wrote:quoted
The question is what "fix it" means. I'm really concerned about AC escapes, and everyone else should be, too.I do think that it might be the right thing to do to add some kind of WARN_ON_ONCE() for AC being set in various can-reschedule situations.So I disagree. Either we set AC with preempt disabled, and then we don't need an extra warning, because we already have a warning about scheduling with preemption disabled, or we accept that the fault handler can run.
n/m about the faults, forgot the obvious :/ I still really dislike wrecking the preemption model over this. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel